Adds more fields and filters to the locations list#1973
Adds more fields and filters to the locations list#1973
Conversation
✅ Deploy Preview for atd-vze-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| maxWidth: "30rem", | ||
| overflow: "hidden", | ||
| textOverflow: "ellipsis", | ||
| whiteSpace: "nowrap", |
There was a problem hiding this comment.
This puts a cap on our extremely long location names
| .dropdown-menu { | ||
| box-shadow: 0 8px 24px rgba(0, 0, 0, 0.12); | ||
| } | ||
|
|
There was a problem hiding this comment.
Adds a shadow to our dropdown menus
johnclary
changed the title
There was a problem hiding this comment.
I think the view bot missed these changes because Rose's PR came in after it.
johnclary
left a comment
johnclary
left a comment
There was a problem hiding this comment.
I left comments on my own PR
johnclary
requested review from
Charlie-Henry,
chiaberry,
frankhereford,
mateoclarke,
mddilley,
roseeichelmann and
tillyw
chiaberry
left a comment
chiaberry
left a comment
There was a problem hiding this comment.
I tested filtering on the new fields and ✔️
I expected the signalized filter to be a toggle yes or no and not able to filter on "yes signalized" and "not signalized" but I see thats how the fields are defined is_signalized_yes and is_signalized_no
The down migration is giving me an error " "cannot drop columns from view". I'll change this comment to approval after its addressed!
There was a problem hiding this comment.
so nice having this diff to review!
|
|
||
| export const locationsListViewQueryConfig: QueryConfig = { | ||
| _version: 2, | ||
| _version: 6, |
There was a problem hiding this comment.
just curious, why did this jump from 2 to 6?
2 participants
Associated issues
Testing
URL to test: Local
On the
/locationslist, use the settings menu to enable visibility of all table columns. Test out the new filter cards on the filter drop down menu. Test out sorting on the Signalized and High injury network columns. Sorting is disabled on the array type columns.On the location details page, observe the additional fields on the Details card
Ship list
mainbranch